This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Batch update meta records #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also adds a comment
replay
requested review from
woodsaj,
robert-milan and
Dieterbe
and removed request for
woodsaj and
robert-milan
Co-Authored-By: Robert Milan <[email protected]>
Co-Authored-By: Robert Milan <[email protected]>
- formatting of docs - return correct count of deleted records on swap
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an API endpoint to batch update all meta records. It also allows the user to specify a
propagateflag, which makes MT fan out the update to all known peers. This is useful for users who want to first pre-generate all their meta records, and then completely replace the currently active set of records with the new generated one.Additionally this PR cleans up the meta tags feature gate a bit. The
MetaTagSupportflag exists in two packages, inidx.memoryandexpr.tagquery. Previously there were unnecessary cross-references between those two packages, which have been cleaned up now.