Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

report readiness per kafka partition #1507

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Conversation

replay
Copy link
Contributor

@replay replay commented Oct 24, 2019

this is necessary for us so we can create an alert to monitor if a partition's data is not served by any instance of Metrictank.

#1492

@Dieterbe
Copy link
Contributor

Dieterbe commented Oct 28, 2019

readiness is a clustering property, even on a per-shard level. thus i think we should report this from the cluster manager, as a clustering metric. i will see if i can tweak this today.

Copy link
Contributor

@Dieterbe Dieterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could maybe merge this right now to get our alerting fixed right now, but we'll need to change the metrics again in the future. see #1492 for my thoughts

Copy link
Contributor

@Dieterbe Dieterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for now

@Dieterbe Dieterbe merged commit 09dc3b5 into master Oct 28, 2019
@Dieterbe Dieterbe deleted the report_per_partition_readiness branch October 28, 2019 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants