Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

Expr package: return proper errors upon bad request from user #1520

Merged
merged 4 commits into from
Nov 5, 2019

Conversation

Dieterbe
Copy link
Contributor

@Dieterbe Dieterbe commented Nov 4, 2019

fix #1462

package github.com/grafana/metrictank/api/response (test)
        imports github.com/grafana/metrictank/idx
        imports github.com/grafana/metrictank/expr/tagquery
        imports github.com/grafana/metrictank/api/response
FAIL    github.com/grafana/metrictank/api/response [setup failed]
Copy link
Member

@woodsaj woodsaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!!!

@Dieterbe Dieterbe merged commit df69121 into master Nov 5, 2019
@Dieterbe Dieterbe deleted the expr-bad-request branch November 5, 2019 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve error handling in query pipeline to set proper http codes
2 participants