This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
correct for delayed lastUpdate updates #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replay
force-pushed
the
correct_for_delayed_lastUpdate
branch
from
8b2b456
to
86655a9
Compare
|
The BigTable index has the same problem, I'll make the same change there. |
Dieterbe
approved these changes
Nov 14, 2019
Dieterbe
added a commit
that referenced
this pull request
Jun 3, 2021
(instead of at previous fix, which did it at query time for Find(), see #1532) This has two main benefits: 1) by making the change to the data, it works equally well across all types of queries, in particular this fixes the behavior for TagQuery 2) we no longer over-eagerly adjust the check at query time (if MT has seen a new point for a given metric - e.g. if the process has been up for a while - than the LastUpdate value in the memory index is perfectly accurate, and we don't need to make any adjustment) fix #1979
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't always update the
lastUpdateproperty in the cassandra index when a metric receives a data point. There can be a delay of up tocassandra-idx.update-interval. To prevent that we falsely exclude a metric based on its delayedlastUpdatetime stamp, we offset thefromparameter by the value ofcassandra-idx.update-intervalat the time whenCasIdx.Find()is called.Fixes: https://github.com/grafana/metrictank-ops/issues/520