Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

Default to tags enabled #1619

Merged
merged 5 commits into from
Jan 22, 2020
Merged

Default to tags enabled #1619

merged 5 commits into from
Jan 22, 2020

Conversation

replay
Copy link
Contributor

@replay replay commented Jan 20, 2020

this feature is not experimental anymore and the additional overhead caused by it is not very large, so we want to enable it by default

CHANGELOG.md Outdated Show resolved Hide resolved
@replay replay added this to the sprint-6 milestone Jan 22, 2020
Copy link
Contributor

@Dieterbe Dieterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase on master and then this is good to go

@replay
Copy link
Contributor Author

replay commented Jan 22, 2020

rebased.
btw @Dieterbe when you write those entries with as of <version> how do you determine the version number to put in there? i think optimally those version numbers would be the commit where this change gets merged into master, but at the point of writing the CHANGELOG i don't think it's possible to predict that hash.

@Dieterbe
Copy link
Contributor

you can't determine in advance.
best is to put whatever you can in the changelog as part of the PR, and do final tweaks like exact version of the change in a followup PR.

@Dieterbe Dieterbe merged commit 6b6f475 into master Jan 22, 2020
@Dieterbe Dieterbe deleted the default_to_tags_enabled branch January 22, 2020 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants