Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

bugfix: return correct counts when deleting multiple tagged series #1641

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

replay
Copy link
Contributor

@replay replay commented Jan 27, 2020

When deleting many paths in one request to /tags/delSeries, the count of deleted metrics gets reset instead of them getting added up.

Using this branch, deleting two paths in one request:

$ curl  'http://localhost:6061/tags/delSeries' -X POST -d 'path=some.id.of.a.metric.1;afewmoretags=forgoodmeasure;anothertag=somelongervalue;goodforpeoplewhojustusetags=forbasicallyeverything;lotsandlotsoftags=morefunforeveryone;manymoreother=lotsoftagstointern;onetwothreefourfivesix=seveneightnineten;os=ubuntu;region=west;secondkey=anothervalue2;thirdkey=onemorevalue' -d 'path=some.id.of.a.metric.3;afewmoretags=forgoodmeasure;anothertag=somelongervalue;goodforpeoplewhojustusetags=forbasicallyeverything;lotsandlotsoftags=morefunforeveryone;manymoreother=lotsoftagstointern;onetwothreefourfivesix=seveneightnineten;os=ubuntu;region=west;secondkey=anothervalue3;thirdkey=onemorevalue' | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   708  100    85  100   623   7727  56636 --:--:-- --:--:-- --:--:-- 64363
{
  "count": 0,
  "peers": {
    "metrictank0": 0,
    "metrictank1": 0,
    "metrictank2": 2,
    "metrictank3": 2
  }
}

@Dieterbe Dieterbe changed the title fix bug in returned deleted counts bugfix: return correct counts when returning tagged series Jan 27, 2020
@Dieterbe Dieterbe changed the title bugfix: return correct counts when returning tagged series bugfix: return correct counts when deleting multiple tagged series Jan 27, 2020
@Dieterbe Dieterbe merged commit 71a1b01 into master Jan 27, 2020
@Dieterbe Dieterbe deleted the fix_bug_in_returned_deleted_counts branch January 27, 2020 22:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants