This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Add aggregate function #1751
Closed
Add aggregate function #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added aggregate function added tags added `last` and `count` aggregator functions added tests added aggregate function aliases made function stable and edited doc when somputing last, return the last non-null val fixed test case added xFilesfactor functions added xff check to aggregate added tests for aggregate with xff split aggregate function so that it can be used byy other functions; added helper function for combining query patterns fixed xff func remove xff vals after computing agg function fixed tests removed unused function added avg_zero
* use new Normalize() correctly * update aggregate tests to use new methods
* xff functions * difference between avg and avg_zero
* iterate in reverse for last function * use more cache-friendly versions for aggregate
Dieterbe
reviewed
Apr 13, 2020
Dieterbe
reviewed
Apr 13, 2020
|
I have a few commits coming to address these points. |
|
replaced by above PR. |
Dieterbe
added a commit
that referenced
this pull request
Apr 13, 2020
add function aggregate. PR #1751 + small tweaks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds the aggregate function
Testing performed
Test files added