Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

add processing function removeEmptySeries #1754

Merged
merged 6 commits into from
Apr 10, 2020

Conversation

vaguiar
Copy link
Contributor

@vaguiar vaguiar commented Apr 6, 2020

Describe your changes
Implementing the function - removeEmptySeries based on the graphite implementation here - https://github.com/graphite-project/graphite-web/blob/master/webapp/graphite/render/functions.py#L5301

Testing performed
Unit tests
Integration tests

Additional context
Added a new test Datapoints to represent a series with all zeros.

Copy link
Contributor

@Dieterbe Dieterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. couple minor tweaks needed

expr/func_removeemptyseries.go Outdated Show resolved Hide resolved
expr/func_removeemptyseries.go Outdated Show resolved Hide resolved
@vaguiar vaguiar changed the title Implementing function removeEmptySeries WIP - Implementing function removeEmptySeries Apr 9, 2020
@Dieterbe Dieterbe changed the title WIP - Implementing function removeEmptySeries add processing function removeEmptySeries Apr 10, 2020
@Dieterbe Dieterbe merged commit 79da281 into grafana:master Apr 10, 2020
@vaguiar vaguiar deleted the func_removeEmptySeries branch April 14, 2020 14:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants