implement /metrics/expand endpoint #1795
Conversation
| @@ -64,6 +64,7 @@ func (s *Server) RegisterRoutes() { | |||
| // Graphite endpoints | |||
| r.Combo("/render", cBody, withOrg, ready, bind(models.GraphiteRender{})).Get(s.renderMetrics).Post(s.renderMetrics) | |||
| r.Combo("/metrics/find", withOrg, ready, bind(models.GraphiteFind{})).Get(s.metricsFind).Post(s.metricsFind) | |||
| r.Combo("/metrics/expand", withOrg, ready, bind(models.GraphiteExpand{})).Get(s.metricsExpand).Post(s.metricsExpand) | |||
There was a problem hiding this comment.
please update docs/http-api.md and docs/cloud/http-api.md
There was a problem hiding this comment.
I added docs in docs/http-api.md.
I'm not sure that it makes sense to also document it in docs/cloud/http-api.md because I think that by adding it there we kind of like recommend to our users to use that endpoint, but in reality it's really mostly redundant to /metrics/find and we only need to support it to be able to claim "graphite compatibility". I think if a user isn't already looking for this specific endpoint because they know it from graphite, there's no need to mention it, it's just cluttering the docs.
There was a problem hiding this comment.
I think we should document it
There was a problem hiding this comment.
ok, i added docs for it
replay
force-pushed
the
metrics_expand
branch
3 times, most recently
from
10406bf
to
950beb0
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@replay please rebase and merge |
|
sure, i'll have to drop my last commit again then, because in the meantime |
|
I've copy-pasted the changes to the cloud docs into this PR: https://github.com/grafana/website/pull/2081 |
Implements the API endpoint
/metrics/expandas documented here.Without it we can't claim to be API compatible with Graphite