This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Add timeShift natively #1873
Merged
Add timeShift natively #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree, we can leave support out for |
robert-milan
approved these changes
Aug 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Implement timeShift natively
Testing performed
test files added
A/B testing against graphite using https://github.com/shanson7/mtcmptest
Additional context
There are a few scenarios that are a little strange:
resetToEnddoes not seem to work when data is retrieved from MT (whether by graphite or natively). I think it's due to padding the data to the requested end.alignToDSTis hard to test on UTC servers :) It uses the server timezone (which I think is misleading to users) and that may be different in the Mt deploy than the graphite deploy