Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

Kafka sasl support #1956

Merged
merged 22 commits into from
Jan 6, 2021
Merged

Conversation

Antoine-Auffret
Copy link
Contributor

Add support for kafka input SASL mechanism SCRAM-SHA-256 and SCRAM-SHA-512

@Antoine-Auffret
Copy link
Contributor Author

Antoine-Auffret commented Jan 5, 2021

Fix breaking changes in ineffassign : gordonklaus/ineffassign#51
Without this fix, the qa job will fail. This must be patched ASAP. @Dieterbe

@Dieterbe
Copy link
Contributor

Dieterbe commented Jan 5, 2021

this looks really good.
can you add validation for ' saslMechanism' to abort if it's not set properly? (e.g. no mechanism or an unrecognized mechanism)

@Antoine-Auffret
Copy link
Contributor Author

this looks really good.
can you add validation for ' saslMechanism' to abort if it's not set properly? (e.g. no mechanism or an unrecognized mechanism)

Thanks for your feedback, I will make those changes

@Dieterbe Dieterbe merged commit 348e8b5 into grafana:master Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants