This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
reduce default kafka-mdm channel-buffer-size #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in prod we use 1000. using too high values will cause the sarama library to consume too much memory when backfilling, which is not reclaimed, leaving a permament increased memory usage footprint. see https://snapshot.raintank.io/dashboard/snapshot/lu1Aw1kPcbx4fk8qdtgZPQ61yyeTwbBk?orgId=2 Even though we plan to switch to the confluent kafka library imminently (#879) it's worthwhile to set this straight, for the record.
woodsaj
approved these changes
Apr 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in prod we use 1000.
using too high values will cause the sarama library to consume too much
memory when backfilling, which is not reclaimed, leaving a permament
increased memory usage footprint.
see
https://snapshot.raintank.io/dashboard/snapshot/lu1Aw1kPcbx4fk8qdtgZPQ61yyeTwbBk?orgId=2
Even though we plan to switch to the confluent kafka library imminently
(#879)
it's worthwhile to set this straight, for the record.
cc @shanson7