This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Schema templates + scylladb docker stack #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* clearer filenames that keep the files together * simpler section names * no such thing as a 'keytable' * no need for global sections * simplify param names and variable names * no need to repeat module/section names, e.g.: flags within cassandra-idx don't need to repeat that no need to mention cassandra or idx in the help info there either * don't list items (table, keyspace) explicitly everywhere, so that we can later add new items if needed with minimal needed changes * mention what the file is actually used for * storage->store * move scylladb files to /usr/share/metrictank/examples * no need to mount scylladb files in any non-default docker image
|
fix #888 |
replay
reviewed
May 2, 2018
util/template.go
Outdated
| if val == nil { | ||
| log.Fatalf("Error %q does not exist in %q", EntryName, TomlFilename) | ||
| } | ||
| return tree.Get(EntryName) |
There was a problem hiding this comment.
this could directly return val to avoid a redundant call to .Get()
replay
approved these changes
May 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is based on @beorn- 's work in #892 with a few commits on top
now we can run
cd docker && ./launch.sh docker-dev-scyllaand it just works!