This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
support adding arbitrary extra tags in jaeger traces #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dieterbe
force-pushed
the
extra-jaeger-tags
branch
from
0a3d7a1
to
7fbbced
Compare
Dieterbe
force-pushed
the
extra-jaeger-tags
branch
from
7fbbced
to
2240c48
Compare
|
is this so we can search for the jaeger tags added by grafana? if so, then that's cool |
|
No this allows us to add arbitrary tags (eg org id) and search on them . |
woodsaj
approved these changes
May 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I verified that they show up in the jaeger UI and that you can search on them too