This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Fix points return measurement overflow #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with large timeframes and/or large number of requests, this could overflow. example: reqs := 500 tsRange := uint32(365 * 2 * 24 * 3600) interval := uint32(1800) fmt.Println(uint32(reqs) * tsRange / interval) fmt.Println(uint32(reqs) * (tsRange / interval)) 817349 <-- WRONG 17520000 <-- CORRECT
Dieterbe
force-pushed
the
fix-points-return-measurement-overflow
branch
from
e8fbd11
to
d59f8dd
Compare
woodsaj
approved these changes
Jun 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.