This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
Fix http4608 #987
Merged
Fix http4608 #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
my concern here is that this reduces our ability to diagnose and resolve the real issue. |
|
That sounds reasonable. Would you want a stack trace of the current goroutine? |
|
good idea. warn + dump stack dump is useful. |
|
Basically, users see "cluster node unavailable" rather than a possibly useful error and I have to dig through logs to figure out what actually happened. |
Dieterbe
approved these changes
Aug 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #984