Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Unit test for ruler not honoring user error
Added new test case in TestRulerMetricsForInvalidQueriesAndNoFetchedSeries with only the invalid query scenario where the user has entered an invalid regex, but without selecting all chunks so the chunks limit doesn't apply. Since only one error happens, the error is of type errors.errorString and not fmt.wrapError, which means the code to detect user errors and cannot type assert to type QueryableError which in turn means it's treated as a GRPC error, which it is not. See https://github.com/grafana/mimir/blob/fdf381290fba868d18762c9790ebf543f49d4cc7/pkg/ruler/compat.go#L164 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
- Loading branch information