Skip to content

Commit

Permalink
Name query metrics for easier discovery (#7302)
Browse files Browse the repository at this point in the history
Changes the way query metrics are named to make them easier to search for.

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
  • Loading branch information
56quarters committed Feb 5, 2024
1 parent 3026016 commit 47deb22
Showing 1 changed file with 8 additions and 12 deletions.
20 changes: 8 additions & 12 deletions pkg/querier/stats/query_metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,24 +41,20 @@ type QueryMetrics struct {
func NewQueryMetrics(reg prometheus.Registerer) *QueryMetrics {
m := &QueryMetrics{
IngesterChunksDeduplicated: promauto.With(reg).NewCounter(prometheus.CounterOpts{
Namespace: "cortex",
Name: "distributor_query_ingester_chunks_deduped_total",
Help: "Number of chunks received from ingesters at query time but discarded as duplicates.",
Name: "cortex_distributor_query_ingester_chunks_deduped_total",
Help: "Number of chunks received from ingesters at query time but discarded as duplicates.",
}),
IngesterChunksTotal: promauto.With(reg).NewCounter(prometheus.CounterOpts{
Namespace: "cortex",
Name: "distributor_query_ingester_chunks_total",
Help: "Number of chunks received from ingesters at query time, including any chunks discarded as duplicates.",
Name: "cortex_distributor_query_ingester_chunks_total",
Help: "Number of chunks received from ingesters at query time, including any chunks discarded as duplicates.",
}),
QueriesRejectedTotal: promauto.With(reg).NewCounterVec(prometheus.CounterOpts{
Namespace: "cortex",
Name: "querier_queries_rejected_total",
Help: "Number of queries that were rejected, for example because they exceeded a limit.",
Name: "cortex_querier_queries_rejected_total",
Help: "Number of queries that were rejected, for example because they exceeded a limit.",
}, []string{"reason"}),
QueriesExecutedTotal: promauto.With(reg).NewCounterVec(prometheus.CounterOpts{
Namespace: "cortex",
Name: "querier_queries_storage_type_total",
Help: "Number of PromQL queries that were executed against a particular storage type.",
Name: "cortex_querier_queries_storage_type_total",
Help: "Number of PromQL queries that were executed against a particular storage type.",
}, []string{"storage"}),
}

Expand Down

0 comments on commit 47deb22

Please sign in to comment.