Skip to content

Commit

Permalink
Create separate Helm value for span queue size
Browse files Browse the repository at this point in the history
  • Loading branch information
charleskorn committed Jan 8, 2024
1 parent 88ac742 commit 5456a48
Show file tree
Hide file tree
Showing 43 changed files with 150 additions and 142 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,11 @@ spec:
- name: "GOMAXPROCS"
value: {{ max $cpu_request_doubled $cpu_request_plus_four | toString | toYaml }}
{{- end }}
{{- $jaeger_queue_size := dig "jaegerReporterMaxQueueSize" nil .Values.querier }}
{{- if $jaeger_queue_size }}
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: {{$jaeger_queue_size | toString | toYaml }}
{{- end }}
envFrom:
{{- with .Values.global.extraEnvFrom }}
{{- toYaml . | nindent 12 }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,11 @@ spec:
- name: "GOMEMLIMIT"
value: {{include "mimir.siToBytes" (dict "value" $mem_request) | toString | toYaml }}
{{- end }}
{{- $jaeger_queue_size := dig "jaegerReporterMaxQueueSize" nil .Values.store_gateway }}
{{- if $jaeger_queue_size }}
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: {{$jaeger_queue_size | toString | toYaml }}
{{- end }}
envFrom:
{{- with .Values.global.extraEnvFrom }}
{{- toYaml . | nindent 12 }}
Expand Down
10 changes: 4 additions & 6 deletions operations/helm/charts/mimir-distributed/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1211,10 +1211,9 @@ querier:
extraContainers: []
extraVolumes: []
extraVolumeMounts: []
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "5000"
env: []
extraEnvFrom: []
jaegerReporterMaxQueueSize: 5000

query_frontend:
# Setting it to null will produce a deployment without replicas set, allowing you to use autoscaling with the deployment
Expand Down Expand Up @@ -1491,10 +1490,9 @@ store_gateway:
extraContainers: []
extraVolumes: []
extraVolumeMounts: []
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "1000"
env: []
extraEnvFrom: []
jaegerReporterMaxQueueSize: 1000

# -- Options to configure zone-aware replication for store-gateway
# Example configuration with full geographical redundancy:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,10 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "5000"
- name: "GOMAXPROCS"
value: "5"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "5000"
envFrom:
nodeSelector:
{}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,12 +149,12 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "1000"
- name: "GOMAXPROCS"
value: "5"
- name: "GOMEMLIMIT"
value: "536870912"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "1000"
envFrom:
---
# Source: mimir-distributed/templates/store-gateway/store-gateway-statefulset.yaml
Expand Down Expand Up @@ -307,12 +307,12 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "1000"
- name: "GOMAXPROCS"
value: "5"
- name: "GOMEMLIMIT"
value: "536870912"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "1000"
envFrom:
---
# Source: mimir-distributed/templates/store-gateway/store-gateway-statefulset.yaml
Expand Down Expand Up @@ -465,10 +465,10 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "1000"
- name: "GOMAXPROCS"
value: "5"
- name: "GOMEMLIMIT"
value: "536870912"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "1000"
envFrom:
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,10 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "5000"
- name: "GOMAXPROCS"
value: "5"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "5000"
envFrom:
nodeSelector:
{}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -140,12 +140,12 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "1000"
- name: "GOMAXPROCS"
value: "5"
- name: "GOMEMLIMIT"
value: "536870912"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "1000"
envFrom:
---
# Source: mimir-distributed/templates/store-gateway/store-gateway-statefulset.yaml
Expand Down Expand Up @@ -289,12 +289,12 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "1000"
- name: "GOMAXPROCS"
value: "5"
- name: "GOMEMLIMIT"
value: "536870912"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "1000"
envFrom:
---
# Source: mimir-distributed/templates/store-gateway/store-gateway-statefulset.yaml
Expand Down Expand Up @@ -438,10 +438,10 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "1000"
- name: "GOMAXPROCS"
value: "5"
- name: "GOMEMLIMIT"
value: "536870912"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "1000"
envFrom:
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,10 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "5000"
- name: "GOMAXPROCS"
value: "5"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "5000"
envFrom:
nodeSelector:
{}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,12 +135,12 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "1000"
- name: "GOMAXPROCS"
value: "5"
- name: "GOMEMLIMIT"
value: "536870912"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "1000"
envFrom:
---
# Source: mimir-distributed/templates/store-gateway/store-gateway-statefulset.yaml
Expand Down Expand Up @@ -279,12 +279,12 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "1000"
- name: "GOMAXPROCS"
value: "5"
- name: "GOMEMLIMIT"
value: "536870912"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "1000"
envFrom:
---
# Source: mimir-distributed/templates/store-gateway/store-gateway-statefulset.yaml
Expand Down Expand Up @@ -423,10 +423,10 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "1000"
- name: "GOMAXPROCS"
value: "5"
- name: "GOMEMLIMIT"
value: "536870912"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "1000"
envFrom:
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,10 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "5000"
- name: "GOMAXPROCS"
value: "5"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "5000"
envFrom:
nodeSelector:
{}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,10 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "1000"
- name: "GOMAXPROCS"
value: "5"
- name: "GOMEMLIMIT"
value: "536870912"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "1000"
envFrom:
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,10 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "5000"
- name: "GOMAXPROCS"
value: "6"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "5000"
envFrom:
nodeSelector:
{}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,12 +149,12 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "1000"
- name: "GOMAXPROCS"
value: "5"
- name: "GOMEMLIMIT"
value: "6442450944"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "1000"
envFrom:
---
# Source: mimir-distributed/templates/store-gateway/store-gateway-statefulset.yaml
Expand Down Expand Up @@ -307,12 +307,12 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "1000"
- name: "GOMAXPROCS"
value: "5"
- name: "GOMEMLIMIT"
value: "6442450944"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "1000"
envFrom:
---
# Source: mimir-distributed/templates/store-gateway/store-gateway-statefulset.yaml
Expand Down Expand Up @@ -465,10 +465,10 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "1000"
- name: "GOMAXPROCS"
value: "5"
- name: "GOMEMLIMIT"
value: "6442450944"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "1000"
envFrom:
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,10 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "5000"
- name: "GOMAXPROCS"
value: "5"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "5000"
envFrom:
nodeSelector:
{}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,10 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "1000"
- name: "GOMAXPROCS"
value: "5"
- name: "GOMEMLIMIT"
value: "536870912"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "1000"
envFrom:
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "5000"
- name: "GOMAXPROCS"
value: "5"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "5000"
envFrom:
nodeSelector:
{}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,12 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "1000"
- name: "GOMAXPROCS"
value: "5"
- name: "GOMEMLIMIT"
value: "536870912"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "1000"
envFrom:
---
# Source: mimir-distributed/templates/store-gateway/store-gateway-statefulset.yaml
Expand Down Expand Up @@ -283,12 +283,12 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "1000"
- name: "GOMAXPROCS"
value: "5"
- name: "GOMEMLIMIT"
value: "536870912"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "1000"
envFrom:
---
# Source: mimir-distributed/templates/store-gateway/store-gateway-statefulset.yaml
Expand Down Expand Up @@ -429,10 +429,10 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "1000"
- name: "GOMAXPROCS"
value: "5"
- name: "GOMEMLIMIT"
value: "536870912"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "1000"
envFrom:
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,10 @@ spec:
- ALL
readOnlyRootFilesystem: true
env:
- name: JAEGER_REPORTER_MAX_QUEUE_SIZE
value: "5000"
- name: "GOMAXPROCS"
value: "5"
- name: "JAEGER_REPORTER_MAX_QUEUE_SIZE"
value: "5000"
envFrom:
nodeSelector:
{}
Expand Down
Loading

0 comments on commit 5456a48

Please sign in to comment.