Skip to content

Commit

Permalink
Fix bug with summing native histograms with query sharding through qu…
Browse files Browse the repository at this point in the history
…ery frontend
  • Loading branch information
zenador committed Apr 11, 2023
1 parent 2b1c552 commit 6449bdb
Showing 1 changed file with 11 additions and 18 deletions.
29 changes: 11 additions & 18 deletions pkg/frontend/querymiddleware/sharded_queryable.go
Original file line number Diff line number Diff line change
Expand Up @@ -249,32 +249,25 @@ func newSeriesSetFromEmbeddedQueriesResults(results [][]SampleStream, hints *sto
}

// same logic as samples above
histograms := make([]mimirpb.Histogram, 0) //, len(stream.Histograms)+10)
/* // for now we will disable query sharding for tenants who enable native histograms, as the changes to support query sharding with native histograms is non-trivial
histograms := make([]mimirpb.Histogram, len(stream.Histograms)+10)

for idx, histogram := range stream.Histograms {
if step > 0 && idx > 0 && histogram.Timestamp > stream.Histograms[idx-1].Timestamp+step {
histograms = append(histograms, model.SampleHistogramPair{
Timestamp: model.Time(stream.Histograms[idx-1].Timestamp + step),
Histogram: model.SampleHistogram{
Sum: model.FloatString(math.Float64frombits(value.StaleNaN)),
},
if step > 0 && idx > 0 && histogram.TimestampMs > stream.Histograms[idx-1].TimestampMs+step {
histograms = append(histograms, mimirpb.Histogram{
Timestamp: stream.Histograms[idx-1].TimestampMs + step,
Sum: math.Float64frombits(value.StaleNaN),
})
}

histograms = append(histograms, model.SampleHistogramPair{
Timestamp: model.Time(histogram.Timestamp),
Histogram: mimirpb.FromMimirSampleToPromCommonHistogram(*histogram.Histogram),
})
histograms = append(histograms, mimirpb.FromFloatHistogramToHistogramProto(histogram.TimestampMs, histogram.Histogram.ToPrometheusModel()))
}

if len(histograms) > 0 && step > 0 {
histograms = append(histograms, model.SampleHistogramPair{
Timestamp: histograms[len(histograms)-1].Timestamp + model.Time(step),
Histogram: model.SampleHistogram{
Sum: model.FloatString(math.Float64frombits(value.StaleNaN)),
},
histograms = append(histograms, mimirpb.Histogram{
Timestamp: histograms[len(histograms)-1].Timestamp + step,
Sum: math.Float64frombits(value.StaleNaN),
})
}*/
}

set = append(set, series.NewConcreteSeries(mimirpb.FromLabelAdaptersToLabels(stream.Labels), samples, histograms))
}
Expand Down

0 comments on commit 6449bdb

Please sign in to comment.