Skip to content

Commit

Permalink
Note experimental flag and add comment
Browse files Browse the repository at this point in the history
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
  • Loading branch information
56quarters committed May 16, 2024
1 parent 01bbb16 commit 6f76a52
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions docs/sources/mimir/configure/about-versioning.md
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ The following features are currently experimental:
- Use of Redis cache backend (`-blocks-storage.bucket-store.chunks-cache.backend=redis`, `-blocks-storage.bucket-store.index-cache.backend=redis`, `-blocks-storage.bucket-store.metadata-cache.backend=redis`)
- `-blocks-storage.bucket-store.series-selection-strategy`
- Eagerly loading some blocks on startup even when lazy loading is enabled `-blocks-storage.bucket-store.index-header.eager-loading-startup-enabled`
- Set a timeout for index-header lazy loading (`-blocks-storage.bucket-store.index-header.lazy-loading-concurrency-queue-timeout`)
- Read-write deployment mode
- API endpoints:
- `/api/v1/user_limits`
Expand Down
3 changes: 3 additions & 0 deletions pkg/storegateway/bucket_stores.go
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,9 @@ func (t timeoutGate) Start(ctx context.Context) error {
defer cancel()

err := t.delegate.Start(ctx)
// Note that we only return an error for a timeout when the delegate has also returned an
// error. This ensures that when we get a slot in the delegate, our caller will call Done()
// and release the slot.
if err != nil && errors.Is(context.Cause(ctx), errGateTimeout) {
_ = spanlogger.FromContext(ctx, log.NewNopLogger()).Error(err)
err = errGateTimeout
Expand Down

0 comments on commit 6f76a52

Please sign in to comment.