Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mimir-prometheus #3175

Closed
2 tasks done
codesome opened this issue Oct 10, 2022 · 4 comments
Closed
2 tasks done

Upgrade mimir-prometheus #3175

codesome opened this issue Oct 10, 2022 · 4 comments
Assignees

Comments

@codesome
Copy link
Member

codesome commented Oct 10, 2022

mimir-prometheus is being synced with upstream Prometheus (here) and it comes with few changes. So I am opening this PR with a checklist of things to do before/when upgrading mimir-prometheus here.

  • Prometheus changed the block meta format for identifying out of order block. We need to update mimir-prometheus to identify both old and new way for the next Mimir release and get rid of old way after 2 releases (that is the usual time to wait to remove something, right?).
  • Overlapping compaction is now enabled by default in TSDB. Make sure to explicitly set it to false for ingesters.
@56quarters 56quarters self-assigned this Oct 20, 2022
@56quarters
Copy link
Contributor

56quarters commented Oct 20, 2022

I merged the update to Prometheus in Mimir without noticing this issue. Overlapping compaction is is false in Mimir but I didn't update mimir-prometheus to identify old and new meta formats. I will begin working on that now.

@56quarters
Copy link
Contributor

If I understand correctly:

So it seems like the first task of changing mimir-prometheus to identify the old and new way is already done (as part of grafana/mimir-prometheus#337)? Can you confirm if this is the case @codesome or have I missed something?

@codesome
Copy link
Member Author

@56quarters you are right, everything is taken care.

@56quarters
Copy link
Contributor

Excellent. I'll open another issue to remove the use of the OutOfOrder bool later. OOO is an experimental feature so I don't think we're under any obligation beyond mentioning it in the changelog. On the other hand, it probably makes sense to do one Mimir release supporting both ways before removing the OutOfOrder bool so we're not purposefully breaking people that wanted to try the feature out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants