Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage release of various iterations of OOO in Mimir 2.5 and 2.6 #3281

Open
56quarters opened this issue Oct 21, 2022 · 0 comments
Open

Manage release of various iterations of OOO in Mimir 2.5 and 2.6 #3281

56quarters opened this issue Oct 21, 2022 · 0 comments

Comments

@56quarters
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Mimir 2.2.0 included the ability to ingest out-of-order samples. That iteration used a boolean OutOfOrder on the BlockMeta struct to indicate that a particular block included out-of-order samples in the mimir-prometheus fork of Prometheus. The upstream version of out-of-order uses a different mechanism to indicate a block has out-of-order samples: a compaction hint on the BlockMetaCompaction.

Describe the solution you'd like

The current version of mimir-prometheus vendored in Mimir (which will end up in Mimir 2.5) uses both of these mechanisms to determine if a block has out-of-order samples. We should do at least one release of Mimir (2.5) with the ability to use both mechanisms before removing the OutOfOrder bool on BlockMeta and using only the upstream Prometheus mechanism in Mimir 2.6

See #3175 #3261 grafana/mimir-prometheus#337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant