Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Review about-tenant-ids.md. #1251

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Conversation

osg-grafana
Copy link
Contributor

Relates to #1109.

For information about how Grafana Mimir components use tenant IDs, refer to [About authentication and authorization]({{<relref "./about-authentication-and-authorization.md" >}}).

## Restrictions

Tenant IDs must be less-than or equal-to 150 bytes/characters in length and must comprise only supported characters:
Tenant IDs must be less-than or equal-to 150 bytes or characters in length and must comprise only supported characters:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pracucci I believe / means or here. Is that so?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"or" is correct here.

@@ -6,12 +6,12 @@ weight: 10

# About tenant IDs

The tenant ID is the unique identifier of a tenant within a Grafana Mimir cluster.
Within a Grafana Mimir cluster, the tenant ID is the unique identifier of a tenant.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opted to provide context before details.

Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically correct.

@osg-grafana osg-grafana merged commit 3c20cdd into main Feb 21, 2022
@osg-grafana osg-grafana deleted the osg-grafana/review-about-tenant branch February 21, 2022 19:53
pracucci pushed a commit that referenced this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants