Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-zone support to jsonnet #1352

Merged
merged 6 commits into from
Mar 2, 2022
Merged

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Mar 2, 2022

What this PR does

We plan to OSS the rollout-operator as part of the Mimir launch, so we can add multi-zone support to our jsonnet too.

Out of scope of this PR: write jsonnet doc.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci requested a review from pstibrany March 2, 2022 11:44
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some multi-zone related changes in our internal grafana-gossip.libsonnet, that can be upstreamed as well.

I would suggest to add extra test with gossip + multizone enabled.

LGTM otherwise.

operations/mimir/multi-zone.libsonnet Outdated Show resolved Hide resolved
operations/mimir/multi-zone.libsonnet Outdated Show resolved Hide resolved
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci merged commit 110f095 into main Mar 2, 2022
@pracucci pracucci deleted the add-multi-zone-support-to-jsonnet branch March 2, 2022 13:55
pracucci added a commit that referenced this pull request Mar 7, 2022
* Added multi-zone support to jsonnet

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Added CHANGELOG entry

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Added jsonnet tests

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Addressed review comments

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Upstreaming gossip + multi-zone too

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Remove gossip_ring_member selector from store-gateway multi-zone service

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci mentioned this pull request Mar 7, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants