Docs: Review performing rolling updates docs #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chri2547
commented
Mar 7, 2022
| Given series are sharded across all ingesters, Grafana Mimir tolerates up to one unavailable ingester. | ||
| By default, ingesters run with a replication factor equal to `3`. | ||
| Ingesters running with the replication factor of `3` require a quorum of two instances to successfully query any series samples. | ||
| Given series are sharded across all ingesters. Grafana Mimir tolerates up to one unavailable ingester. |
There was a problem hiding this comment.
@pracucci , not sure what 'Given' means here. Can you please clarify? Thank you.
There was a problem hiding this comment.
"Given" means "Since" in this context and the comma was intentional in the original sentence.
pracucci
approved these changes
Mar 7, 2022
| Given series are sharded across all ingesters, Grafana Mimir tolerates up to one unavailable ingester. | ||
| By default, ingesters run with a replication factor equal to `3`. | ||
| Ingesters running with the replication factor of `3` require a quorum of two instances to successfully query any series samples. | ||
| Given series are sharded across all ingesters. Grafana Mimir tolerates up to one unavailable ingester. |
There was a problem hiding this comment.
"Given" means "Since" in this context and the comma was intentional in the original sentence.
chri2547
commented
Mar 7, 2022
docs/sources/operating-grafana-mimir/performing-a-rolling-update.md
Outdated
Show resolved
Hide resolved
…te.md Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
pracucci
added a commit
that referenced
this pull request
Mar 7, 2022
* Docs: Review performing rolling updates docs * Update docs/sources/operating-grafana-mimir/performing-a-rolling-update.md Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1104