Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagrams for deployment-modes page updated to remove grey background #1471

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Diagrams for deployment-modes page updated to remove grey background #1471

merged 1 commit into from
Mar 14, 2022

Conversation

09jvilla
Copy link
Contributor

@09jvilla 09jvilla commented Mar 12, 2022 •
edited
Loading

We made the update for the diagrams on the architecture.md page (see related PR #1459) so we should do the same for these.

Fixes https://github.com/grafana/mimir-squad/issues/564

@09jvilla 09jvilla self-assigned this Mar 12, 2022
@09jvilla 09jvilla requested a review from pracucci March 12, 2022 22:41
pracucci
pracucci approved these changes Mar 14, 2022
View reviewed changes
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pracucci pracucci merged commit fbc8d18 into main Mar 14, 2022
@pracucci pracucci deleted the diagram-no-grey branch March 14, 2022 08:40
pracucci pushed a commit that referenced this pull request Mar 14, 2022
@09jvilla @pracucci
All diagrams updated. (#1471)
fa627d9
@pracucci pracucci mentioned this pull request Mar 14, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pracucci pracucci pracucci approved these changes

Assignees

@09jvilla 09jvilla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@09jvilla @pracucci