Mimir admin landing CSS #1482
Merged
Mimir admin landing CSS #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some CSS styling to the mimir admin. Brings basic CSS and JS (jQuery) dependencies to this repository so we don't need to fetch stuff from the internet, which opens the door for better inner tables, etc. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
pracucci
approved these changes
Mar 15, 2022
| } | ||
|
|
||
| func (pc *IndexPageContent) AddLink(section, path, description string) { | ||
| type IndexPageNavElement struct { | ||
| weight int |
There was a problem hiding this comment.
Other fields are exposed, but weight is not. Any specific reason?
There was a problem hiding this comment.
This is only used to sort the items before providing them to the template, but template doesn't need to know about the weight.
Co-authored-by: Marco Pracucci <marco@pracucci.com>
colega
added a commit
that referenced
this pull request
Mar 15, 2022
Was so excited about merging that I forgot to update the CHANGELOG.md Ref: #1482 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
pracucci
pushed a commit
that referenced
this pull request
Mar 15, 2022
Was so excited about merging that I forgot to update the CHANGELOG.md Ref: #1482 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
|
Based on screenshot only: hiding links behind disclosure buttons makes them more difficult to find. I would prefer to have all actions visible (and searchable via browser search function) when I visit the admin page, although some CSS to split sections and make it nicer overall would be welcome. |
|
I will revisit this 👍 |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This adds some CSS styling to the Mimir's admin landing page.
Embeds basic CSS (Bootstrap) and JS (jQuery) dependencies to this repository so we don't need to fetch stuff from the internet, which opens the door for better inner components' tables, etc.
I can't keep working on this due to higher priorities, but I'd like to hear opinions (I have some offline ones already)
Preview
I've refactored the landing page to be categorised by component, with specific links in the dropdowns:
Even though I tried to keep everything simple, I'm still doubtful about dropdowns, and would like to hear opinions.
Which issue(s) this PR fixes or relates to
None, this was my hackathon-ish work during oncall.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]