Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Revise readme #1489

Merged
merged 10 commits into from
Mar 16, 2022
Merged

Docs: Revise readme #1489

merged 10 commits into from
Mar 16, 2022

Conversation

chri2547
Copy link
Contributor

Relates to #1486

@chri2547 chri2547 marked this pull request as draft March 15, 2022 18:30
@chri2547 chri2547 self-assigned this Mar 15, 2022
@chri2547 chri2547 added the type/docs Improvements or additions to documentation label Mar 15, 2022
@chri2547 chri2547 changed the title Revise readme doc Docs: Revise readme Mar 15, 2022
README.md Outdated Show resolved Hide resolved
README.md Outdated

## Contributing

To contribute to Grafana Mimir, see [Contributing to Grafana Mimir](./CONTRIBUTING.md).
To contribute to Grafana Mimir, refer to [Contributing to Grafana Mimir](./CONTRIBUTING.md).

## Hosted Grafana Mimir (Prometheus as a service)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdbaldry , @KMiller-Grafana , @pracucci , this content is from the original readme, so I left it. Not sure if we should remove it.

README.md Outdated Show resolved Hide resolved
README.md Outdated

Your feedback is always welcome.

## Further Reading
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdbaldry , @KMiller-Grafana , @pracucci , same here, lifted this from the Loki docs in case we have links to additional content. I suppose that we probably don't at this point, so I'm fine with removing it. Just wanted to check.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should link the videos and blog posts we prepared for the Mimir launch. I think the URLS won't be available until last minute, so I would remove this section so we can get this PR merged sooner and then open a PR at launch to add it with the right links.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd vote for that too. Do we have a place for just-before/just-after launch tasks?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a place for just-before/just-after launch tasks?

Richi's launch tracker.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added a post-launch column to https://github.com/orgs/grafana/projects/120/views/1 where I'm tracking fast-follow work. I'll add a card there about enhancing the readme with links to blogs and videos.

README.md Outdated
[kccna18-slides]: https://speakerdeck.com/davkal/on-the-path-to-full-observability-with-oss-and-launch-of-loki
[kccna18-video]: https://www.youtube.com/watch?v=U7C5SpRtK74&list=PLj6h78yzYM2PZf9eA7bhWnIh_mK1vyOfU&index=346

## Building from source
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdbaldry , @KMiller-Grafana , @pracucci , again, taken from Loki. I'm not sure what we'd put in here that isn't already covered in the deployment docs (which Jen is working on as I write...).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section shouldn't be part of the README. I would remove it from here.

@pracucci pracucci mentioned this pull request Mar 16, 2022
3 tasks
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated

Your feedback is always welcome.

## Further Reading
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should link the videos and blog posts we prepared for the Mimir launch. I think the URLS won't be available until last minute, so I would remove this section so we can get this PR merged sooner and then open a PR at launch to add it with the right links.

README.md Outdated
[kccna18-slides]: https://speakerdeck.com/davkal/on-the-path-to-full-observability-with-oss-and-launch-of-loki
[kccna18-video]: https://www.youtube.com/watch?v=U7C5SpRtK74&list=PLj6h78yzYM2PZf9eA7bhWnIh_mK1vyOfU&index=346

## Building from source
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section shouldn't be part of the README. I would remove it from here.

@chri2547 chri2547 requested a review from pracucci March 16, 2022 20:10
@chri2547 chri2547 marked this pull request as ready for review March 16, 2022 20:10
README.md Outdated Show resolved Hide resolved
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion

@jdbaldry jdbaldry enabled auto-merge (squash) March 16, 2022 20:19
@jdbaldry jdbaldry merged commit 33b9fdf into main Mar 16, 2022
@jdbaldry jdbaldry deleted the revise-readme-doc branch March 16, 2022 20:32
pracucci added a commit that referenced this pull request Mar 21, 2022
* in-process copy edit

* copy edit continues

* in-process draft

* Update README.md

Co-authored-by: Marco Pracucci <marco@pracucci.com>

* Update README.md

Co-authored-by: Marco Pracucci <marco@pracucci.com>

* incorporated first batch of feedback

* addressed final feedback

* adjusted doc URLs to latest

* removed reference to apache exceptions

* Fix typo

Co-authored-by: Marco Pracucci <marco@pracucci.com>
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
@pracucci pracucci mentioned this pull request Mar 21, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants