Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimirtool config: Add duration list tests for YAML #1508

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

dimitarvdimitrov
Copy link
Contributor

Signed-off-by: Dimitar Dimitrov dimitar.dimitrov@grafana.com

What this PR does

  • adds a test case for converting YAML duration lists
  • changes existing test case for duration list as flags to have values different from the defaults

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pstibrany pstibrany merged commit 7af43e9 into main Mar 18, 2022
@pstibrany pstibrany deleted the dimitar/duration-list-yaml-tests branch March 18, 2022 14:14
pracucci pushed a commit that referenced this pull request Mar 21, 2022
* Add duration list tests for YAML

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Make duration list test values diff from default

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@pracucci pracucci mentioned this pull request Mar 21, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants