mimirtool config: small migration and flags output convenience #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
…cortex Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
replay
reviewed
Mar 18, 2022
Co-authored-by: Mauro Stettler <mauro.stettler@gmail.com>
pstibrany
reviewed
Mar 21, 2022
pracucci
pushed a commit
that referenced
this pull request
Mar 21, 2022
* Output only YAML when only YAML was provided (same for CLI flags) Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Set frontend.results_cache.backend when results cache was enabled in cortex Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Sort output flags Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * My own nitpicks Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update pkg/mimirtool/config/convert.go Co-authored-by: Mauro Stettler <mauro.stettler@gmail.com> * Update pkg/mimirtool/config/convert_test.go Co-authored-by: Mauro Stettler <mauro.stettler@gmail.com> Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
frontend.results_cache.backend, which has only a single valuememcachedand is empty by default. The backend hasn't changed since cortex, so this new flag needs to be set when cortex'squery_range.cache_results==trueserver.http_listen_port:80when the port wasn't explicitly set), this YAML is confusing and is likely to be ignored even though it shouldn't be. This PR changes the tool to output in the same format as the input filespruneNils, it is replaced by anifinInspectedEntry.MarshalYAMLWhich issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]