-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mimirtool config: GEM conversions & ring.instance_id #1513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. <
encoding as \u003c
is fine, and "prefix" fields are coming from Cortex structs with doc:"hidden"
tags. Missing )
in addresses
field is also correct, and should be fixed in Cortex first.
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
89eddd0
to
18e9eb4
Compare
@pstibrany I've moved the GEM-specific removed options to |
I resolved comments that are not a concern anymore. |
* Add GEM-specific conversions Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update tests for GEM Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update GEM descriptor Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update descriptors with hidden fields Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Set instance-ids for GEM's admin-api too Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Make tests pass & move GEM removed options to gem.go Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
What this PR does
convert_test.go
:server.http_listen_port
and from now also GEM'sauth.type
)server.http_listen_port
)-ingester.lifecycler.id
and-distributor.ring.instance_id
)instance_id
in GEM and Mimir 2.0 withnull
- this is done manually until we can support the dynamic flags (ones that detect the default value automatically)Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]