Docs: move dashboards to hugo bundles #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
8 tasks
jdbaldry
approved these changes
Mar 21, 2022
Makefile
Outdated
| @@ -468,7 +468,7 @@ mixin-serve: ## Runs Grafana (listening on port 3000) loading the mixin dashboar | |||
| @./operations/mimir-mixin-tools/serve/run.sh | |||
|
|
|||
| mixin-screenshots: ## Generates mixin dashboards screenshots. | |||
| @rm -f docs/sources/images/dashboards/*.png | |||
| @find docs/sources/operators-guide/visualizing-metrics/dashboards -name '*.png' | xargs rm | |||
There was a problem hiding this comment.
It's considered safer to use -delete or -print0 | xargs -0 rm to handle files with spaces and stuff
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
added a commit
that referenced
this pull request
Mar 21, 2022
* Moved dashboards to Hugo bundles Signed-off-by: Marco Pracucci <marco@pracucci.com> * Updated screenshot generator tool and screenshots Signed-off-by: Marco Pracucci <marco@pracucci.com> * Addressed review feedback Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This is the 1st PR to migrate docs to Hugo bundles. This PR addresses the dashboard images. I've also took the opportunity to update the screenshots, so we're ready for 2.0.0 final.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]