Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Adds migrate from cortex video #1545

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Conversation

chri2547
Copy link
Contributor

Relates to #1524

@chri2547 chri2547 self-assigned this Mar 24, 2022
@chri2547 chri2547 added the type/docs Improvements or additions to documentation label Mar 24, 2022
@jdbaldry
Copy link
Member

Haven't watched the video yet, do we need any context around it to explain it similar to what we needed with the other video that was added?

@jdbaldry
Copy link
Member

That is to say, how much does this video differ from the documentation it is being added to.

@chri2547
Copy link
Contributor Author

I don't know. I can review the video to see if I can make that determination, but would love your thoughts, as well.

@@ -20,6 +20,10 @@ The changes focus on making Grafana Mimir easier to run out of the box, includin
The `mimirtool` automates configuration conversion.
It provides a simple migration by generating Mimir configuration from Cortex configuration.

{{< vimeo 691929138 >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having watched the video, I think this is best moved to the section about migrating with Jsonnet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdbaldry , and ready for review, approval, and merge.

@chri2547 chri2547 requested a review from jdbaldry March 24, 2022 20:36
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks Chris!

@jdbaldry jdbaldry merged commit afb751d into main Mar 24, 2022
@jdbaldry jdbaldry deleted the adds-migrate-from-cortex-video branch March 24, 2022 20:51
pracucci pushed a commit that referenced this pull request Mar 28, 2022
* adds vimeo code

* adds migration video

* moves video to jsonnet section
@pracucci pracucci mentioned this pull request Mar 28, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants