Remove dropdowns from Mimir Admin's landing #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't like the dropdowns, and Peter gave the same feedback. The issue about dropdowns is that you have to click stuff to find information that should be in the first level. This is also more accessible. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
pstibrany
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
To add some separation without too much added vertical space (it seems that padding inside boxes plus margins between boxes are higher than the text on the page), I would try simple horizontal lines between sections.
But this is still an improvement over hiding links by default, so 👍
pstibrany
reviewed
Mar 25, 2022
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
force-pushed
the
review-mimir-admin-landing-css
branch
from
83ec229
to
11722a3
Compare
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
|
Applied the feedback, this is how it looks like now:
|
|
Love it, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
I didn't like the dropdowns, and @pstibrany gave the same feedback. The issue about dropdowns is that you have to click stuff to find information that should be in the first level. This is also more accessible.
This is how it looks like now:
And it gracefully scales to mobile:
Which issue(s) this PR fixes or relates to
None
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]