mimir-jsonnet: allow disabling ingester anti-affinity #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While setting up Mimir on my personal toy-cluster of one node, I got stuck scheduling the ingesters as they have the anti-affinity rules by default and it can't be easily removed without redefining the statefulset. There are similar configs for distributor, querier, etc., so I just added another one, and documented it a little bit. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
pracucci
approved these changes
Mar 31, 2022
| @@ -95,7 +95,7 @@ | |||
| statefulSet.mixin.spec.withPodManagementPolicy('Parallel') + | |||
| (if with_anti_affinity then $.util.antiAffinity else {}), | |||
|
|
|||
| ingester_statefulset: self.newIngesterStatefulSet('ingester', $.ingester_container), | |||
| ingester_statefulset: self.newIngesterStatefulSet('ingester', $.ingester_container, !$._config.ingester_allow_multiple_replicas_on_same_node), | |||
There was a problem hiding this comment.
You may also want to check it in newIngesterZoneStatefulSet().
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
|
Hmm, what's wrong with the cla check? It won't run 🤷 |
pracucci
reviewed
Mar 31, 2022
| @@ -86,7 +86,7 @@ | |||
| newIngesterZoneStatefulSet(zone, container):: | |||
| local name = 'ingester-zone-%s' % zone; | |||
|
|
|||
| self.newIngesterStatefulSet(name, container, with_anti_affinity=false) + | |||
| self.newIngesterStatefulSet(name, container, with_anti_affinity=!$._config.ingester_allow_multiple_replicas_on_same_node) + | |||
There was a problem hiding this comment.
Doh! This should always be false, because this function injects a different anti-affinity rule below (see spec+:). What I meant in the other comment is that we should inject the custom anti-affinity rule only if ingester_allow_multiple_replicas_on_same_node: false.
There was a problem hiding this comment.
I should have paid more attention to that, thank you.
This should be the fix: 3d534a7
|
Had the same problem yesterday (with CLA check not running), it fixed itself after pushing an empty commit ( |
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
pracucci
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
While setting up Mimir on my personal toy-cluster of one node, I got stuck scheduling the ingesters as they have the anti-affinity rules by default and it can't be easily removed without redefining the statefulset. There are similar configs for distributor, querier, etc.,
so I just added another one, and documented it a little bit.
Which issue(s) this PR fixes or relates to
None
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]