Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added range query support to write-read-series-test in mimir-continuous-test tool #1603

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Apr 1, 2022

What this PR does

In this PR I'm adding support to query back written series (using range query) to write-read-series-test in mimir-continuous-test tool.

At each interval, after writing series the tool query back the time range successfully written until that point in time. The queried time ranges are:

  • Last 1h
  • Last 24h
  • From last 23h to last 24h
  • Random time range (up until the configured max query age)

Out of the scope of this PR (will be done in follow up PRs):

  • Test instant query
  • Query results cache disabled too
  • Find the previously written samples at startup, so that it can continue write and read after a restart
  • CHANGELOG
  • Doc

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

…us-test tool

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci requested a review from pstibrany April 1, 2022 08:37
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check all the unit tests thoroughly, but series testing logic seems solid. Nice work.

pkg/continuoustest/write_read_series.go Outdated Show resolved Hide resolved
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci merged commit 006cad8 into main Apr 1, 2022
@pracucci pracucci deleted the add-query-to-continuous-testing-tool branch April 1, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants