Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixin: Show in-memory series and the per-user limit on Tenants dashboard. #1613

Merged
merged 3 commits into from
Apr 4, 2022

Conversation

stevesg
Copy link
Contributor

@stevesg stevesg commented Apr 1, 2022

What this PR does

Changes the "Active series" panel on the "Tenants" dashboard to show:

  • Current number of in-memory series for the tenant
  • The current in-memory series limit (either from overrides or the default)

This information is extremely valuable to operators tasked with troubleshooting when tenants are hitting limits, or whether they are close to hitting limits. Looking at only active series often causes confusion because limits are applied to the number of in-memory series, not active series.

Which issue(s) this PR fixes or relates to

Fixes n/a

Checklist

  • n/a Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@stevesg stevesg force-pushed the tenants-dashboard-memory-series branch from 2b3733f to f1e671a Compare April 1, 2022 18:18
@stevesg stevesg force-pushed the tenants-dashboard-memory-series branch from f1e671a to 858b248 Compare April 1, 2022 18:23
@stevesg stevesg marked this pull request as ready for review April 1, 2022 18:27
@stevesg stevesg requested a review from a team April 1, 2022 18:32
Copy link
Contributor

@treid314 treid314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES 🎉 This is so helpful for questions about limits and how limits are actually enforced. My Hero!

Copy link
Contributor

@osg-grafana osg-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking with nit to conform to style by removing &.

CHANGELOG.md Outdated Show resolved Hide resolved
@stevesg stevesg merged commit f21026d into main Apr 4, 2022
@stevesg stevesg deleted the tenants-dashboard-memory-series branch April 4, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants