Added mimir-continuous-test alerts #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
colega
reviewed
Apr 11, 2022
| for: 1h | ||
| labels: | ||
| severity: warning | ||
| - alert: MimirContinuousTestNotRunning |
There was a problem hiding this comment.
I'd use a different alert name for writes and queries. Message isn't used for grouping, so both of these would fall into the same group.
There was a problem hiding this comment.
Good point. Will fix.
colega
approved these changes
Apr 11, 2022
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In this PR I'm adding 2 class of alerts on
mimir-continuous-test:MimirContinuousTestNotRunningfiring when the test is not running properlyMimirContinuousTestFailedfiring when the testing tool is running, but assertions are failingSeverity is
warningfor now, but plan is to raise it after gaining some confidence on the tool.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]