Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alertmanager: Set a Pod Disruption Budget #1683

Merged
merged 4 commits into from
Apr 12, 2022
Merged

Alertmanager: Set a Pod Disruption Budget #1683

merged 4 commits into from
Apr 12, 2022

Conversation

gotjosh
Copy link
Contributor

@gotjosh gotjosh commented Apr 12, 2022

What this PR does

By default, we enforce a replication factor of 3 which the Alertmanager inherits. To ensure quorum is not lost during disruptions we set a pod disruption budget of withMaxUnavailable(1).

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • N/A Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

By default, we enforce a replication factor of 3 which the Alertmanager inherits. To ensure quorum is not lost during disruptions we set a pod disruption budget of `withMaxUnavailable(1)`.
@CLAassistant
Copy link

CLAassistant commented Apr 12, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM (modulo a nit)

CHANGELOG.md Outdated Show resolved Hide resolved
@gotjosh gotjosh enabled auto-merge (squash) April 12, 2022 13:12
@gotjosh gotjosh merged commit 013ca70 into main Apr 12, 2022
@gotjosh gotjosh deleted the pdb-alertmanager branch April 12, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants