Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixin/Playbooks: Add Alertmanager suggestions for MimirRequestErrors and MimirRequestLatency #1702

Merged
merged 5 commits into from
Apr 14, 2022

Conversation

gotjosh
Copy link
Contributor

@gotjosh gotjosh commented Apr 14, 2022

What this PR does

Both MimirRequestErrors and MimirRequestLatency can fire for Alertmanager components. Add a brief explanation of where/what to look when this happens for the Alertmanager.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • N/A Tests updated
  • N/A Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@gotjosh gotjosh force-pushed the request-and-lantecy-error-include-am branch from ac2f4ea to c925dd0 Compare April 14, 2022 13:10
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (modulo a couple of nits). Thanks!

operations/mimir-mixin/docs/playbooks.md Outdated Show resolved Hide resolved
operations/mimir-mixin/docs/playbooks.md Outdated Show resolved Hide resolved
operations/mimir-mixin/docs/playbooks.md Outdated Show resolved Hide resolved
gotjosh and others added 3 commits April 14, 2022 14:29
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
@gotjosh gotjosh enabled auto-merge (squash) April 14, 2022 13:30
@gotjosh gotjosh merged commit d501e8b into main Apr 14, 2022
@gotjosh gotjosh deleted the request-and-lantecy-error-include-am branch April 14, 2022 13:46
@@ -214,6 +214,23 @@ How to **investigate**:
- If memcached eviction rate is high, then you should scale up memcached replicas. Check the recommendations by `Mimir / Scaling` dashboard and make reasonable adjustments as necessary.
- If memcached eviction rate is zero or very low, then it may be caused by "first time" queries

#### Alertmanager

How to **investigate**:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be a transitive verb ("How to investigate [what]:")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants