Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] disable unregister on shutdown #1994

Merged
merged 1 commit into from
Jun 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions operations/helm/charts/mimir-distributed/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ Entries should be ordered as follows:

Entries should include a reference to the Pull Request that introduced the change.

## 2.1.0-beta.6

* [ENHANCEMENT] Disable `ingester.ring.unregister-on-shutdown` and `distributor.extend-writes` #1994
- This will prevent resharding every series during a rolling ingester restart
- Under some circumstances the previous values (both enabled) could cause write path degredation during rolling restarts

## 2.1.0-beta.5

* [ENHANCEMENT] Add support for the results cache used by the query frontend #1993
Expand Down
2 changes: 1 addition & 1 deletion operations/helm/charts/mimir-distributed/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
apiVersion: v2
version: 2.1.0-beta.5
version: 2.1.0-beta.6
appVersion: 2.0.0
description: "Grafana Mimir"
engine: gotpl
Expand Down
2 changes: 1 addition & 1 deletion operations/helm/charts/mimir-distributed/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Helm chart for deploying [Grafana Mimir](https://grafana.com/docs/mimir/v2.0.x/)

# mimir-distributed

![Version: 2.1.0-beta.5](https://img.shields.io/badge/Version-2.1.0--beta.5-informational?style=flat-square) ![AppVersion: 2.0.0](https://img.shields.io/badge/AppVersion-2.0.0-informational?style=flat-square)
![Version: 2.1.0-beta.6](https://img.shields.io/badge/Version-2.1.0--beta.6-informational?style=flat-square) ![AppVersion: 2.0.0](https://img.shields.io/badge/AppVersion-2.0.0-informational?style=flat-square)

Grafana Mimir

Expand Down
4 changes: 4 additions & 0 deletions operations/helm/charts/mimir-distributed/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,14 @@ mimir:
compactor:
data_dir: "/data"
distributor:
extend_writes: false
ingester:
ring:
final_sleep: 0s
num_tokens: 512
unregister_on_shutdown: false
ingester_client:
grpc_client_config:
Expand Down