Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric for error codes resulting from forwarding requests #2077

Merged

Conversation

replay
Copy link
Contributor

@replay replay commented Jun 10, 2022

We need to get insight into errors returned by forwarding targets, this adds a metric to track the errors by tenant and status code.

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
@replay replay marked this pull request as ready for review June 10, 2022 14:47
Copy link
Contributor

@treid314 treid314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Makes sense

Copy link
Contributor

@osg-grafana osg-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small amount of ambiguity in the term "from".

pkg/distributor/forwarding/forwarding.go Outdated Show resolved Hide resolved
replay and others added 6 commits June 13, 2022 11:01
Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
@replay replay merged commit b794cf2 into main Jun 15, 2022
@replay replay deleted the add_metric_for_error_codes_resulting_from_forwarding_requests branch June 15, 2022 15:37
masonmei pushed a commit to udmire/mimir that referenced this pull request Jul 11, 2022
…a#2077)

* add metric for error codes resulting from forwarding requests

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* add unit test for forwarding errors

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* linter

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* PR feedback

Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>

* key metric by target instead of user

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* improve help text

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* update tests to expect updated help string

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* updated to key by target

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

* remove target and tenant labels

Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>

Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants