Report global limit in error msg for tenant rate limited errors #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replay
approved these changes
Jun 15, 2022
pracucci
reviewed
Jun 16, 2022
… confusing to the user
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Jul 11, 2022
…ana#2104) * Report global limit in error msg for tenant rate limited errors * Revise error msg for ingestion and request rate limits to remove info confusing to the user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Improves message for per-tenant rate limit errors by reporting global limit instead of local, and removing info confusing to the user.
Which issue(s) this PR fixes or relates to
Fixes #2082 according to user feedback in #2081
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]