Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set shuffle sharding ingester lookback automatically #2110

Merged
merged 3 commits into from
Jun 20, 2022

Commits on Jun 15, 2022

  1. Set shuffle sharding ingester lookback automatically

    This change deprecates the
    `querier.shuffle-sharding-ingesters-lookback-period` option, instead
    setting the lookback period from the value of the
    `querier.query-ingesters-within` option. Outside of our own integration
    tests, there's no situation where it's useful to set the lookback period
    to a different value than the `query-ingesters-within` option.
    
    This also adds a new option `querier.shuffle-sharding-ingesters-enabled`
    that can be used to enable or disable shuffle sharding on ingesters on
    the read path instead of using the lookback period for this.
    
    Fixes #1810
    
    Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
    56quarters committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    37b7a7d View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. Code review changes

    Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
    56quarters committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    aaa8cbf View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2022

  1. Code review changes

    Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
    56quarters committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    8cea648 View commit details
    Browse the repository at this point in the history