Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compactor: Enable TSDB block upload on per-tenant basis #2126

Merged
merged 10 commits into from
Jun 20, 2022

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Jun 17, 2022

What this PR does

Modify the compactor to enable TSDB block upload on a per-tenant basis.

Which issue(s) this PR fixes or relates to

Checklist

  • Tests updated
  • Documentation added
  • [na] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@aknuds1 aknuds1 force-pushed the feat/per-tenant-backfill branch 3 times, most recently from fb97c2a to 2fc7f96 Compare June 17, 2022 12:51
@aknuds1 aknuds1 requested review from pstibrany and a team June 17, 2022 12:52
@aknuds1 aknuds1 marked this pull request as ready for review June 17, 2022 12:52
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm overall. It would be nice to reduce PR diff as suggested in block_upload_test.go comments.

pkg/compactor/block_upload.go Outdated Show resolved Hide resolved
pkg/compactor/block_upload_test.go Outdated Show resolved Hide resolved
pkg/compactor/block_upload_test.go Outdated Show resolved Hide resolved
pkg/compactor/block_upload_test.go Outdated Show resolved Hide resolved
pkg/util/validation/limits.go Outdated Show resolved Hide resolved
aknuds1 and others added 7 commits June 20, 2022 11:35
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1 aknuds1 requested a review from pstibrany June 20, 2022 13:08
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Let's mention new CLI option name in the CHANGELOG entry for the backfilling feature (entry for PR #1694)

@aknuds1
Copy link
Contributor Author

aknuds1 commented Jun 20, 2022

Thank you. Let's mention new CLI option name in the CHANGELOG entry for the backfilling feature (entry for PR #1694)

@pstibrany yeah good point.

@aknuds1 aknuds1 requested a review from pstibrany June 20, 2022 14:06
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@aknuds1 aknuds1 merged commit 5d136e1 into main Jun 20, 2022
@aknuds1 aknuds1 deleted the feat/per-tenant-backfill branch June 20, 2022 14:08
masonmei pushed a commit to udmire/mimir that referenced this pull request Jul 11, 2022
* Compactor: Enable block upload on per-tenant basis
* Update changelog

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants