-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compactor: Enable TSDB block upload on per-tenant basis #2126
Conversation
fb97c2a
to
2fc7f96
Compare
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2fc7f96
to
46c6e4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm overall. It would be nice to reduce PR diff as suggested in block_upload_test.go comments.
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
…nto feat/per-tenant-backfill
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Let's mention new CLI option name in the CHANGELOG entry for the backfilling feature (entry for PR #1694)
@pstibrany yeah good point. |
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
* Compactor: Enable block upload on per-tenant basis * Update changelog Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
What this PR does
Modify the compactor to enable TSDB block upload on a per-tenant basis.
Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]