Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GossipMembersMismatch misfiring with remote ruler eval #2159

Merged
merged 3 commits into from
Jun 21, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion operations/mimir-mixin-compiled/alerts.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ groups:
message: Mimir instance {{ $labels.pod }} in {{ $labels.cluster }}/{{ $labels.namespace
}} sees incorrect number of gossip members.
expr: |
avg by (cluster, namespace) (memberlist_client_cluster_members_count) != sum by (cluster, namespace) (up{job=~".+/(alertmanager|compactor|distributor|ingester.*|querier.*|ruler|store-gateway.*|cortex|mimir)"})
avg by (cluster, namespace) (memberlist_client_cluster_members_count) != sum by (cluster, namespace) (up{job=~".+/(alertmanager|compactor|distributor|ingester.*|(ruler-)?querier.*|ruler|store-gateway.*|cortex|mimir)"})
for: 15m
labels:
severity: warning
Expand Down
2 changes: 1 addition & 1 deletion operations/mimir-mixin/config.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
ruler_query_frontend: '(ruler-query-frontend.*)', // Match also custom ruler-query-frontend deployments.
query_scheduler: 'query-scheduler.*', // Not part of single-binary. Match also custom query-scheduler deployments.
ruler_query_scheduler: 'ruler-query-scheduler.*', // Not part of single-binary. Match also custom query-scheduler deployments.
ring_members: ['alertmanager', 'compactor', 'distributor', 'ingester.*', 'querier.*', 'ruler', 'store-gateway.*', 'cortex', 'mimir'],
ring_members: ['alertmanager', 'compactor', 'distributor', 'ingester.*', '(ruler-)?querier.*', 'ruler', 'store-gateway.*', 'cortex', 'mimir'],
dimitarvdimitrov marked this conversation as resolved.
Show resolved Hide resolved
store_gateway: '(store-gateway.*|cortex|mimir)', // Match also per-zone store-gateway deployments.
gateway: '(gateway|cortex-gw|cortex-gw-internal)',
compactor: 'compactor.*|cortex|mimir', // Match also custom compactor deployments.
Expand Down