Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixin: Convert "Slow Queries" dashboard to Grafana 9.0 #2223

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

dimitarvdimitrov
Copy link
Contributor

What this PR does

The loki data format changed in grafana 9.0. This broke the Slow Queries dashboard.

This is what the resulting dashboard looks on Grafana v9.0.0-adfe4ef5pre (adfe4ef56)

Screenshot 2022-06-24 at 12 52 34

The change is not compatible with versions prior to Grafana 9.0

Signed-off-by: Dimitar Dimitrov dimitar.dimitrov@grafana.com

Which issue(s) this PR fixes or relates to

Fixes #2119

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We've already cut Mimir 2.2 changelog. Could you rebase and the 2 CHANGELOG entries up in the CHANGELOG, please?

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@dimitarvdimitrov dimitarvdimitrov force-pushed the dimitar/fix-slow-queries-dashboard branch from f82a183 to 95f891d Compare July 5, 2022 07:40
@pracucci pracucci enabled auto-merge (squash) July 5, 2022 07:42
@pracucci pracucci merged commit e9c7566 into main Jul 5, 2022
@pracucci pracucci deleted the dimitar/fix-slow-queries-dashboard branch July 5, 2022 08:23
masonmei pushed a commit to udmire/mimir that referenced this pull request Jul 11, 2022
* mixin: Fix slow queries dashboard on grafana 9.0

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Add CHANGELOG.md entries

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow queries dashboard is not supported by grafana 9
2 participants