Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update thanos vendor to latest grafana/thanos@out-of-order commit #2408

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Update thanos vendor to latest grafana/thanos@out-of-order commit #2408

merged 2 commits into from
Jul 18, 2022

Conversation

56quarters
Copy link
Contributor

@56quarters 56quarters commented Jul 13, 2022 •
edited
Loading

Signed-off-by: Nick Pillitteri nick.pillitteri@grafana.com

What this PR does

Specifically, we want to pull in thanos-io/thanos#5451 for Azure blob
storage improvements.

Which issue(s) this PR fixes or relates to

Fixes #2229
Fixes #2232

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@56quarters 56quarters marked this pull request as ready for review July 13, 2022 17:12
@56quarters
Copy link
Contributor Author

56quarters commented Jul 13, 2022 •
edited
Loading

I did a check of the dependencies that saw major version increases, we don't use any of them directly.

@pracucci
Copy link
Collaborator

Anything worth to note (or focus on when reviewing) among the Thanos changes? I can see many of them.

@56quarters
Copy link
Contributor Author

Anything worth to note (or focus on when reviewing) among the Thanos changes? I can see many of them.

The only relevant one to me looks like thanos-io/thanos@79ab7c6, downloading and uploading blocks in parallel.

@56quarters
Copy link
Contributor Author

Anything worth to note (or focus on when reviewing) among the Thanos changes? I can see many of them.

The only relevant one to me looks like thanos-io/thanos@79ab7c6, downloading and uploading blocks in parallel.

Seems potentially useful to expose to speed up compactors but I think that can be done in a follow up PR. Created an issue here #2421

@56quarters 56quarters requested review from pracucci and a team July 14, 2022 16:12
pracucci
pracucci approved these changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked all Thanos changes, and briefly checked all other changes (except for the MD5 assembler). Nothing particularly stands out to me, so LGTM!

@56quarters
Update thanos vendor to latest grafana/thanos@out-of-order commit
c0c7eb9 
Specifically, we want to pull in thanos-io/thanos#5451 for Azure blob
storage improvements.

Fixes #2229

Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
@56quarters
Modules fix
347368d 
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
@56quarters 56quarters enabled auto-merge (squash) July 18, 2022 13:30
@56quarters 56quarters merged commit b8cf3fa into main Jul 18, 2022
@56quarters 56quarters deleted the 56quarters/thanos-update branch July 18, 2022 13:50
@pracucci pracucci mentioned this pull request Jul 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pracucci pracucci pracucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@56quarters @pracucci