mimirtool: validate that overwriting objects is supported #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate that the object storage backend supports `Upload`s to existing objects and will overwrite their contents. Fixes #2490 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
force-pushed
the
56quarters/overwrite-validation
branch
from
199abf9
to
72e6f2b
Compare
replay
reviewed
Jul 20, 2022
| @@ -254,6 +262,8 @@ func (b *BucketValidationCommand) validateTestObjects(ctx context.Context) error | |||
| if err != nil { | |||
| return errors.Wrapf(err, "failed to read object (%s)", objectPath) | |||
| } | |||
|
|
|||
| _ = reader.Close() | |||
replay
approved these changes
Jul 20, 2022
That's a good call, to make sure the update didn't just silently get eaten. |
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nick Pillitteri nick.pillitteri@grafana.com
What this PR does
Validate that the object storage backend supports
Uploads to existingobjects and will overwrite their contents.
Which issue(s) this PR fixes or relates to
Fixes #2490
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]